[SOLVED] Post processing

Ashley_Solano · February 20, 2023, 7:22pm

We are trying to add an effect on our credits scene.
We downloaded the script, added to our assets and attached the script to the camera in our scene. However we are getting this error.
[playcanvas-1.60.0.dbg.js:8935]: Cannot read properties of undefined (reading ‘indexOf’)

What may be causing this?
Link to editor: https://playcanvas.com/editor/scene/1609368

slimbuck · February 20, 2023, 9:34pm

Hmm I’m not sure what’s going on here. Looks like this post process effect has been written against engine v1.61 (the current engine version is v1.60).

If you run the launch page and specify engine v1.61 (which btw should be released tomorrow), it seems to work. Try it like so.

Where did you get this post process script?

@mvaligursky might have more context here.

Thanks

Ashley_Solano · February 20, 2023, 9:43pm

I got the post process script here

github.com

playcanvas/engine/blob/main/scripts/posteffects/posteffect-huesaturation.js

// --------------- POST EFFECT DEFINITION --------------- //
/**
 * @class
 * @name HueSaturationEffect
 * @classdesc Allows hue and saturation adjustment of the input render target.
 * @description Creates new instance of the post effect.
 * @augments PostEffect
 * @param {GraphicsDevice} graphicsDevice - The graphics device of the application.
 * @property {number} hue Controls the hue. Ranges from -1 to 1 (-1 is 180 degrees in the negative direction, 0 no change, 1 is 180 degrees in the postitive direction).
 * @property {number} saturation Controls the saturation. Ranges from -1 to 1 (-1 is solid gray, 0 no change, 1 maximum saturation).
 */
function HueSaturationEffect(graphicsDevice) {
    pc.PostEffect.call(this, graphicsDevice);

    // Shader author: tapio / http://tapio.github.com/
    var fshader = [
        "uniform sampler2D uColorBuffer;",
        "uniform float uHue;",
        "uniform float uSaturation;",
        "",

This file has been truncated. show original

slimbuck · February 20, 2023, 9:48pm

Ahh ok that makes sense then! Github main branch is the bleeding edge, which is currently roughly engine v1.61.

For v1.60 you would have to use engine/posteffect-huesaturation.js at release-1.60 · playcanvas/engine · GitHub instead.

However, as I mentioned before we should be updating the editor to engine v1.61 tomorrow and so what you have now will work.

Thanks!

Tirk182 · February 20, 2023, 11:23pm

@Ashley_Solano I am not sure if this is the issue or not but I see that this script is in the camera entity. @slimbuck may have better insight into this. Also, looking at the menu script I see.

var MenuScene = pc.createScript('menuScene');

// initialize code called once per entity
MenuScene.prototype.initialize = function() {

};

// update code called every frame
MenuScene.prototype.update = function(dt) {
if (this.app.keyboard.wasPressed(pc.KEY_SPACE)) {


    window.open("https://launch.playcanvas.com/1603948","_self");

     }
};

This will not work when published and has nothing to do with this issue but while I was looking at the code I noted this.

Ashley_Solano · February 21, 2023, 5:14pm

We are following a written curriculum from E-dynamics learning and it specifically tells students to attach the script to the camera. Would you suggest something else?
Also the MenuScene script is also from a step in the curriculum and it does work when the game is launched as far as using keys to open a new scene within the game.
What would be the problem there?
Thanks for the help!
Also the post effect is working today!

Tirk182 · February 22, 2023, 12:28am

@Ashley_Solano I am just addressing

Yes this method will work perfectly every time the game is launched locally from the editor. If the student publishes the game this type of reference will not work at all.