[SOLVED] Missing definitions in .d.ts in engine

Help & Support
1

I ran into these two small fixes I needed to do to the generated .d.ts file for the engine:

add to Application:
lightmapper: pc.Lightmapper;

change the first param of Lightmapper.back to allow null:
bake(nodes: pc.Entity[] | null, mode?: number): void;

Also, the current tags.add() only allows a single string parameter, not an array, and not an arbitrary list of params.

(Sorry, I don’t have time to fix this properly and submit a PR, and wanted to drop it here before I forget)

2 Likes
2

Ooo, well spotted @blairmacintyre. If you could log here, I’d really appreciate it! :smile:

3

oh, right, of course. Done.

1 Like
4

PR submitted: https://github.com/playcanvas/engine/pull/2459

1 Like