Content-type works on all files except Audio files

Four-K · May 3, 2023, 5:44pm

When obfuscating filename extensions everything works except audio files. Looking at the audio code it has checks that rely on the extension rather than just the content-type received (which can be defined in the content-type header for the folder the files are within). I think this is an easy fix to pull it inline with the rest of PlayCanvas but maybe there are other reasons for this.

Leonidas · May 4, 2023, 7:33am

Hi @Four-K,

That’s interesting, I wasn’t aware audio worked like that.

Could you raise an issue in the engine repo about it?

yaustar · May 4, 2023, 9:26am

Hmm, you may want to check where it fails in the engine as the only place I can see is here:

github.com

playcanvas/engine/blob/96141aad3a19b4d3744a14c4f5198f4416a018d2/src/framework/handlers/audio.js#L73


      
           * @param {import('../app-base.js').AppBase} app - The running {@link AppBase}.
           * @hideconstructor
           */
          constructor(app) {
              this.manager = app.soundManager;
              Debug.assert(this.manager, "AudioSourceComponentSystem cannot be created without sound manager");
          
          
    this.maxRetries = 0;
          }
          
          
_isSupported(url) {
              const ext = path.getExtension(url);
          
          
    return supportedExtensions.indexOf(ext) > -1;
          }
          
          
load(url, callback) {
              if (typeof url === 'string') {
                  url = {
                      load: url,
                      original: url

And I think you could patch that function in your project if need be

Four-K · May 6, 2023, 8:12pm

Hi @Leonidas - yes, just done that (see below).
Hi @yaustar - yes that seems to be the place as it checks if the URL has a filename extension is amongst:
var supportedExtensions = [‘.ogg’, ‘.mp3’, ‘.wav’, ‘.mp4a’, ‘.m4a’, ‘.mp4’, ‘.aac’, ‘.opus’];

See issue here: Content-Type Header ignored for Audio files · Issue #5309 · playcanvas/engine · GitHub

yaustar · May 7, 2023, 7:32am

In which case, I would go with the suggestion I made earlier about making a small engine patch in the project to remove the check.