Cancel loading?

memleak · August 25, 2021, 10:50pm

Hello guys,

I have an app that have a lot of runtime dynamic loading. Is there a way to cancel a file that start loading?

Loading as been triggered like this:

texture.ready(onTextureReady);
app.assets.load(texture);

Thanks!

Mykel

yaustar · August 26, 2021, 8:38am

Not at the moment, no. Your best workaround here is to add an unload function to the ready callback if you want to ‘cancel’ it.

There’s a couple of tickets around this but it isn’t as straightforward as I would like it to be to implement:

github.com/playcanvas/engine

Give more control and information to the developer when loading resources

opened 10:22AM - 27 Apr 20 UTC

yaustar

feature request

Related issues: #737 Asset loader should retry failed assets #494 assets.load… and assets.loadFromUrl to return XHR object if one created internally Currently the resource loader is not resilient to unstable networks (such as mobile) and doesn't give much control or information (such as progress) back to the client. This makes it very difficult for the client to know if a load has stalled or going very slowly to make the decision to retry or notify the user if the network connection has dropped. Taking `pc.SceneRegistry.loadSceneHierarchy` for example: https://github.com/playcanvas/engine/blob/master/src/framework/scene-registry.js#L144 ``` SceneRegistry.prototype.loadSceneHierarchy = function (url, callback) { var self = this; // Because we need to load scripts before we instance the hierarchy (i.e. before we create script components) // Split loading into load and open var handler = this._app.loader.getHandler("hierarchy"); // include asset prefix if present if (this._app.assets && this._app.assets.prefix && !pc.ABSOLUTE_URL.test(url)) { url = pc.path.join(this._app.assets.prefix, url); } handler.load(url, function (err, data) { if (err) { if (callback) callback(err); return; } // called after scripts are preloaded var _loaded = function () { self._app.systems.script.preloading = true; var entity = handler.open(url, data); self._app.systems.script.preloading = false; // clear from cache because this data is modified by entity operations (e.g. destroy) self._app.loader.clearCache(url, "hierarchy"); // add to hierarchy self._app.root.addChild(entity); // initialize components pc.ComponentSystem.initialize(entity); pc.ComponentSystem.postInitialize(entity); if (callback) callback(err, entity); }; // load priority and referenced scripts before opening scene self._app._preloadScripts(data, _loaded); }); }; ``` The request is made to the handler which makes the call to `pc.HierarchyHandler.load` https://github.com/playcanvas/engine/blob/master/src/resources/hierarchy.js#L10 ``` load: function (url, callback) { if (typeof url === 'string') { url = { load: url, original: url }; } var assets = this._app.assets; pc.http.get(url.load, { retry: this.retryRequests }, function (err, response) { if (!err) { pc.TemplateUtils.waitForTemplatesInScene( response, assets, callback); } else { var errMsg = 'Error while loading scene ' + url.original; if (err.message) { errMsg += ': ' + err.message; if (err.stack) { errMsg += '\n' + err.stack; } } else { errMsg += ': ' + err; } callback(errMsg); } }); }, ``` But it (and other handlers) do not handle or return the XHR object which could be used to check progress and abort the request if need be. Proposals: - [ ] Any resource handler should return a handle that wraps the XHR object to allow the client to abort a load - [ ] Any public API that does a load request should return this handle - [ ] The `err` returned in the callback ([example](https://github.com/playcanvas/engine/blob/master/src/resources/hierarchy.js#L29)) should be an object with an error code and string rather than just a string when an error occurs. Questions: * Should the engine track progress as well or should that be optional for the client? * Should the engine retry requests as #737 mentions or be optional for the client? * Should the handle object be able to do the abort or should there be a matching `cancel*` function to any `load*` function?