Basis Failed to Transcode on iOS 17

derek9nine · September 20, 2023, 2:57am

I have a site that has been live and running fine for the last 11 days:

Built, tested, and running perfectly on PC, Mac, iOS, Android.
I have an older iPhone 11 and today I upgraded to iOS 17. Now my site will not load on my phone and the errors are basis files failing to transcode (both chrome and safari)

Tried running out of the editor and I get the same issue.

Using engine ver 1.65.3

Is there a newer version I can be using? Please help as 90% of our traffic is mobile and more than half of that is iOS.

Screenshots attached.

Leonidas · September 20, 2023, 3:27am

Hi @derek9nine,

I don’t have an iPhone iOS 17 to check right now, but this is indeed quite important if Basis fails to load. Pinging the PlayCanvas team @will @mvaligursky @slimbuck

derek9nine · September 20, 2023, 3:29am

Thanks for the help @Leonidas

I just found this issue:

github.com/playcanvas/engine

Basis Failed to transcode image (Safari 17.0, iOS 17.0)

opened 06:49PM - 26 Jul 23 UTC

cd-vaughamhong

bug area: graphics

Hello! We recently upgraded to Playcanvas 1.64.4 and basis transcode has stop…ped working for some platforms. * Safari 17.0. (OSX Ventura 13.4.1 (c)) * iOS 17.0. (Console errors) <img width="1161" alt="Screenshot 2023-07-26 at 11 10 41 AM" src="https://github.com/playcanvas/engine/assets/121981001/9caf7045-456e-4bc3-b89a-7d4413443018"> (basis-worker.js) <img width="949" alt="Screenshot 2023-07-26 at 11 37 21 AM" src="https://github.com/playcanvas/engine/assets/121981001/05c05e05-af74-4ecc-a276-5807f70ce778"> Our basisInitialize config: `{ “glueUrl":"(some url)/assets/lib/basis/basis.wasm.js", "wasmUrl":"(some url)/assets/lib/basis/basis.wasm.wasm", "fallbackUrl":"(some url)/assets/lib/basis/basis.js", "maxRetries":3, "rgbPriority":["etc1","etc2","astc","dxt","pvr","atc"], "rgbaPriority":["astc","dxt","etc2","pvr","atc"] }` If we force the fallback path (via hard coding wasmSupport to false) instead of compileStreaming / compileManual, our basis images do load properly. (basis.js) <img width="817" alt="Screenshot 2023-07-26 at 11 39 26 AM" src="https://github.com/playcanvas/engine/assets/121981001/a6e9f865-0e65-4486-b9ff-681f662e2eba"> Let me know if there is any other info you’d like me to gather / follow up on. Any workarounds (other than forcing fallback) would be great!

going to attempt the workaround suggested

NEVER MIND
After looking at the bug I realized they are working w/ the engine source, and we have been working out of the editor.
Need an editor based solution so I can deploy a fix.

derek9nine · September 20, 2023, 4:03am

Just to make sure I’m not going crazy, the engine examples PlayCanvas Examples
as posted by @mvaligursky in the open issue fails to transcode on my phone.
Star-Lord, however, doesn’t throw any errors.

EDIT: Tried rolling back the engine version in the editor and still get transcode errors (both last patch and last minor) so it likely wasn’t something recently introduced.

slimbuck · September 20, 2023, 7:56am

Hi @derek9nine,

We believe this is a regression in iOS 17. I reported the bug a month ago, but there haven’t been any updates:

https://bugs.webkit.org/show_bug.cgi?id=260252

Thanks!

mvaligursky · September 20, 2023, 9:46am

By the way, we’re investigating and looking for possible workarounds.
The issues can be reproduced both on iOS 17, but also on MacOS Safari 17.

derek9nine · September 20, 2023, 7:04pm

Follow up. @mvaligursky @slimbuck

I grabbed the source from tag 1.65.3 and forced the basis handler to manually compile using the fallback script (line 58 of src/framework/handlers/basis.js). This solves the iOS 17 issue and everything seems to be good across all devices.

Is there going to be a performance hit by not using the wasm when transcoding the textures? That would be my biggest concern, but I do need to get a fix out the door ASAP

mvaligursky · September 20, 2023, 7:40pm

There’s likely going to be a perf hit, but how that will affect your project you might need to test - as that depends on compression type / texture sizes / counts. It might be ok as a workaround.

We have some existing workaround for safari 15.4 - perhaps you can temporarily apply your workaround for 17.0 only, so it will only affect small number of people.

github.com

playcanvas/engine/blob/871f68c938a506c62de1a32e92817f7fdbf9c74a/src/platform/graphics/webgl/webgl-graphics-device.js#L354-L356


      
          // #4136 - turn off antialiasing on AppleWebKit browsers 15.4
          const ua = (typeof navigator !== 'undefined') && navigator.userAgent;
          this.forceDisableMultisampling = ua && ua.includes('AppleWebKit') && (ua.includes('15.4') || ua.includes('15_4'));

derek9nine · September 20, 2023, 7:58pm

Real quick question on that check, is the ua variable a string so if I check if it includes “17.” and “17_” it should cover all versions for 17 for the time being yeah? Or do I need to test against specific versions of the OS?

mvaligursky · September 20, 2023, 7:59pm

yeah I’d go with “17.” and “17_”

derek9nine · September 20, 2023, 8:34pm

If anyone stumbles upon this pre-WebKit fix and needs a solution, here’s what I did:

Downloaded the source for the version of the engine we are using (1.65.3 for me)
Opened up src/framework/handlers/basis.js
Changed the code to not use the wasm on iOS 17
Rebuilt the engine
Replaced the min.js in my project

basis_fix821×275 36.1 KB

slimbuck · September 21, 2023, 11:31am

I’ve submitted Handle ios 17 basis wasm regression by slimbuck · Pull Request #5657 · playcanvas/engine · GitHub which should deal with this issue.

@derek9nine if you have any time to test this fix on your assets I’d be very grateful.

Thanks!

derek9nine · September 21, 2023, 1:35pm

@slimbuck Will be testing this morning.
Thanks again for the quick responses and help with a work around! Y’all rock

derek9nine · September 21, 2023, 3:59pm

@slimbuck Is this fix dependent upon any other engine changes? Because we’ve been using 1.65.3 I took your code change and applied it to my local basis-worker.js and rebuilt the engine after removing my iOS 17 check from the previous workaround

I am getting a different error now evaluating S[b-1].buffer

slimbuck · September 21, 2023, 5:09pm

Hi @derek9nine, any chance you can send me the texture(s) causing the issue then I can investigate locally?

derek9nine · September 21, 2023, 9:19pm

@slimbuck Trying to figure out the best way to accomplish that right now
We have 30+ textures using basis and the assets that throw errors never finish loading asset wise so my loading screens stay up the whole time

The errors now don’t log the failed asset because it is syntax as opposed to console.error. Will dig into it a bit more tomorrow and try to figure it out

Searching the engine source for S[b-1].buffer gets me nothing
Searching project code for the same gets me nothing. Wondering now if it is from a different wasm and the fix affected it. Not really sure how that would be possible if the same number of mips are being used

mvaligursky · September 21, 2023, 9:40pm

I think that S[b-1] is the code you took from the fix PR … just renamed by the bundler.

derek9nine · September 22, 2023, 1:45pm

Makes sense. Does the bundler also strip out console logging?

mvaligursky · September 22, 2023, 1:48pm

I don’t think so, console. code should stay.

Grimmy · September 25, 2023, 12:09pm

Just to let you know. We are getting this on iOS 17 too. Will this be fixed in the engine anytime soon? Thanks