[SOLVED] Rectangle light source

vogloblinsky · July 28, 2021, 8:25pm

Just added in my project :

pc.LayerComposition.clusteredLightingEnabled = true;
pc.app.scene.layers.clusteredLightingCells = new pc.Vec3(20, 2, 20);
pc.app.scene.layers.clusteredLightingMaxLights = 48;

and i have this warning in Chrome 91 / macOS Big Sur 11.4

[.WebGL-0x7fee69cb5600]GL ERROR :GL_INVALID_OPERATION : glDrawElements: Texture bound to texture unit 0 with internal format GL_DEPTH_COMPONENT32F is not compatible with sampler type GL_SAMPLER_2D

Is there a documentation about these options ?

Leonidas · July 28, 2021, 8:36pm

The API is still in the works, the example is your best bet and you can also check the source code here:

github.com

playcanvas/engine/blob/826d23cf5d80a99e2ee3602baf8fd46c30415a59/src/scene/world-clusters.js

import { Vec3 } from '../math/vec3.js';
import { math } from '../math/math.js';
import { BoundingBox } from '../shape/bounding-box.js';
import { Texture } from '../graphics/texture.js';
import { PIXELFORMAT_R8_G8_B8_A8, PIXELFORMAT_RGBA32F, ADDRESS_CLAMP_TO_EDGE, TEXTURETYPE_DEFAULT, FILTER_NEAREST } from '../graphics/constants.js';
import { LIGHTTYPE_DIRECTIONAL, LIGHTTYPE_SPOT } from './constants.js';

const tempVec3 = new Vec3();
const tempMin3 = new Vec3();
const tempMax3 = new Vec3();
const tempBox = new BoundingBox();

const epsilon = 0.000001;
const oneDiv255 = 1 / 255;
const maxTextureSize = 4096;    // maximum texture size allowed to work on all devices

// packs a float value in [0..1) range to specified number of bytes and stores them in an array with start offset
// based on: https://aras-p.info/blog/2009/07/30/encoding-floats-to-rgba-the-final/
// Note: calls to Math.round are only needed on iOS, precision is somehow really bad without it,
// looks like an issue with their implementation of Uint8ClampedArray

This file has been truncated. show original

vogloblinsky · July 28, 2021, 9:23pm

Ok, i have tryied to update parameters but it didn’t change anything.

I have another question on lighting topic. Many elements in my scene are static, like buildings.

If i understand well, using lightmaps could be a good performance improvement.

My building model don’t have “Lightmapped” option activated, so shadows are calculated in realtime. If i activate the option, i have the warning “UV1 is missing”.
When i check the model, i didn’t have the “Pipeline” option on the right panel, like in the doc (Runtime Lightmaps | Learn PlayCanvas)

Link to scene : https://playcanvas.com/editor/scene/1091565

yaustar · July 29, 2021, 8:41am

Unfortunately, unwrap UV is not available with GLB at the moment. You would either have to use the older JSON format or unwrap the UVs in the modelling program before importing them

See: UV auto-unwrap is not supported for GLB model assets · Issue #194 · playcanvas/editor · GitHub

eproasim · July 29, 2021, 12:15pm

Good morning @yaustar,

I noticed in my projects that when selecting a model that has a UV1 to be lightmapped, the editor will still say that UV1 is missing. Since I had my own lightmaps, it didn’t affect me much, but seeing this thread, I thought I would mention it here.

yaustar · July 29, 2021, 12:32pm

Yep, if you have baked the lightmaps outside of PlayCanvas, that works as well.

The UV1 is needed for runtime or Editor lightmapping

eproasim · July 29, 2021, 12:45pm

I understand,

What I mean is choosing a RenderElement that does indeed have a UV1 will still show as having no UV1 when selected for lightmapping in the editor for runtime lightmaps.

yaustar · July 29, 2021, 1:08pm

Oh interesting. Can you create an issue on the Editor repo with an example FBX that we can look at please?

eproasim · July 29, 2021, 2:33pm

Issue submitted: Editor always reports Missing UV1 on RenderComponents · Issue #478 · playcanvas/editor · GitHub

Repro: https://playcanvas.com/editor/scene/1202294

mvaligursky · August 10, 2021, 6:20pm

The clustered lighting is a way to go with many lights. I’m not sure what the problem is with that warning you get, it’s not something obvious. Do you not get that warning when clustered lights are disabled?

Without clustered lights, you should be able to enable / disable lights as needed, but each time a new number of lights is used a new shader gets compiled, which takes 100s of ms for more complex shaders. Eventually the cache would contain all variants needed, but that’s not a solution.