Playcanvas-spine plugin incompatible with latest Playcanvas runtime

inductible · December 7, 2018, 4:58pm

Heya,

I’m using playcanvas-spine plugin; it appears that this doesn’t work with playcanvas 1.10.7 (confirm working last in 1.10.6) - there’s no runtime error; the animation simply won’t play, as if it’s not getting updated.

Current solution: stick with playcanvas 1.10.6

inductible · December 7, 2018, 5:15pm

It’s something to do with this commit: https://github.com/playcanvas/engine/commit/d27a44b6d732c0f1bab94ef5126050db16a1d914

…which needs a corresponding tweak in playcanvas-spine runtime, I’d wager.

yaustar · December 7, 2018, 5:49pm

Good catch on finding the change. Looks like an easy fix from changing one line?

github.com

playcanvas/playcanvas-spine/blob/master/src/plugin/component/spine-component-system.js#L23


        'atlasData',
        'textures',
        'skeletonData',
        'speed',
        'spine'
    ];


    this.on('remove', this.onRemove, this);
    // this.on('update', this.onUpdate, this);


    pc.ComponentSystem.on('update', this.onUpdate, this);


};
SpineComponentSystem = pc.inherits(SpineComponentSystem, pc.ComponentSystem);


pc.extend(SpineComponentSystem.prototype, {
    initializeComponentData: function (component, data, properties) {
        properties = ['enabled', 'atlasAsset', 'textureAssets', 'skeletonAsset', 'atlasData', 'textures', 'skeletonData', 'spine'];
        SpineComponentSystem._super.initializeComponentData.call(this, component, data, properties);
    },

You can most likely just make the change locally in the minified version as it’s a single line.

inductible · December 7, 2018, 7:25pm

Sweet - I’ll give that a shot when I’m back at work!

Thanks for your help

yaustar · December 7, 2018, 10:43pm

I’ve tested this fix on an old Spine project and submitted a PR: https://github.com/playcanvas/playcanvas-spine/pull/10