Error...probably due to memory overflow

ayrin · February 3, 2018, 1:22pm

If this abort() is unexpected, build with -s ASSERTIONS=1 which can give more information.

ayrin · February 3, 2018, 3:14pm

I guess it’s a memory problem due to the use of destroy function that seems to not clear the memory creating garbage but don’t know how to solve that

yaustar · February 3, 2018, 11:52pm

It’s a bit weird that it’s happening in ammo.js. What code is triggering this error?

ayrin · February 4, 2018, 12:06am

That’s a good question, i can tell you how to replicate it: https://playcanvas.com/editor/scene/396696 launch the game from editor, the M key open the map, travel to Rekdar or Foren, travel back to Leas’ Bones and again to Rekdar or Foren and you will get that error i think the terrain.js is where the error is triggered, that’s where i put the code to generate towns and where the unnecessary entities are destroyed.

yaustar · February 4, 2018, 12:22am

Your project is getting to a point where it’s very hard for an outside person to debug easily.

I recommend trying to narrow down what is causing that bug to occur by commenting chunks of code and think through the possibilities.

Eg:

Does it happen when you don’t destroy entities?
Does it happen if you only destroy one entity?
Is it one particular entity or one particular group of entities causing this?

ayrin · February 4, 2018, 12:50am

It’s very hard to debug for me too the only reference i can use is the terrain.js 175:13 that point this

            this.entity.removeComponent('collision');
            this.entity.model.model = model;
            this.entity.addComponent('collision', {
                type: 'mesh'
            });     // <-----line 175
            this.entity.collision.model = collisionModel;

ayrin · February 4, 2018, 9:00pm

Yes the problem is due for sure when re-creating the phisical shape of terrain maybe i’m missing something to erase the memory?

yaustar · February 4, 2018, 9:38pm

Check the memory profile in Chrome Dev tools.

Part of me is wondering if you are using too much memory by creating the collision model each time you enter and return to the town? Perhaps the it isn’t being destroyed properly in Ammo?

Is the terrain destroyed when you exit each area?

ayrin · February 4, 2018, 9:42pm

Nope isn’t destroyed, this is the code when enter each area

changeTerrain: function() {
            var house=app.root.findByTag('house');
            for(var x=0;x<house.length;x++) {
                
                house[x].destroy();
            }
            this.lM=app.root.findByName('Player').script.player.localMap;
            var img = app.assets.get(this.heightMap[this.lM]).resource.getSource();
            var model = this.createTerrainFromHeightMap(img);
            var collisionModel = this.createTerrainFromHeightMap(img, this.subdivisions / 2);
            var buildings = app.assets.get(this.dbTowns).resource;
            
            var oggdata = this.parseTownData(buildings);
            this.entity.removeComponent('model');
            this.entity.model=null;
            this.entity.addComponent('model', {
                type: 'asset'
            });
            //this.entity.model.castShadows=true;
            this.entity.removeComponent('rigidbody');
            this.entity.rigidbody=null;
            this.entity.addComponent('rigidbody', {
                type: 'static'
            });
            this.entity.rigidbody.friction=1;

            this.entity.removeComponent('collision');
            this.entity.collision=null;
            this.entity.model.model = model;
            this.entity.addComponent('collision', {
                type: 'mesh'
            });
            this.entity.collision.model = collisionModel;
            
            this.placeBuildings();
        },

yaustar · February 4, 2018, 9:56pm

I get the feeling that when you remove the rigidbody, you don’t actually delete the collision mesh from the physics world but without really checking the engine code, I’m not 100% sure.

I recommend looking at the engine code and potentially ammo.js to see what options you have from removing a rigidbody from the world.

ayrin · February 5, 2018, 9:46am

Can’t find anything useful ;_;

ayrin · February 5, 2018, 9:49pm

It’s totally a memory overflow trouble, i changed a bit the code in terrain.js and the line where the error show up is changed.