Engine Release: v1.66.0

LeXXik · October 8, 2023, 6:42am

Everyone, please note the breaking change in Tween library.

Previously:

entity
.tween(entity.getLocalPosition())
.to({x: 10, y: 0, z: 0}, 1, pc.Linear)
.on('complete', function () {
   console.log('tween completed');
})
.start();

Starting from 1.66:

entity
.tween(entity.getLocalPosition())
.to({x: 10, y: 0, z: 0}, 1, pc.Linear)
.onComplete(() => {
   console.log('tween completed');
})
.start();

Same for update and loop events.

You would need to update the Tween library to the latest (thank you, @kungfooman ). You can grab one here:

github.com

playcanvas/playcanvas-tween/blob/main/tween.js

pc.extend(pc, function () {

    /**
     * @name pc.TweenManager
     * @description Handles updating tweens
     * @param {pc.AppBase} app - The AppBase instance.
     */
    var TweenManager = function (app) {
        this._app = app;
        this._tweens = [];
        this._add = []; // to be added
    };

    TweenManager.prototype = {
        add: function (tween) {
            this._add.push(tween);
            return tween;
        },

        update: function (dt) {

This file has been truncated. show original

Further details in PR:

github.com/playcanvas/playcanvas-tween

onUpdate, onComplete, onLoop methods instead of events

playcanvas:main ← Maksims:event-handle

opened 10:02AM - 16 Aug 23 UTC

Maksims

+37 -19

Based on recent PR (https://github.com/playcanvas/engine/pull/5481) to the engin…e, it has a breaking change where `EventEmitter.on` does not return "self" for chaining, but returns `EventHandle`. This breaks the ways were recommended by this library. **Unfortunately, after the 1.66 engine update, migration by users of this library will be required.** To avoid it, this PR introduces three new methods: `onUpdate`, `onComplete`, `onLoop` to be used instead of events notation. So this code: ```js entity .tween(entity.getLocalPosition()) .to({x: 10, y: 0, z: 0}, 1, pc.Linear) .on('complete', function () { console.log('tween completed'); }) .start(); ``` Now should be: ```js entity .tween(entity.getLocalPosition()) .to({x: 10, y: 0, z: 0}, 1, pc.Linear) .onComplete(() => { console.log('tween completed'); }) .start(); ``` The same applies to `update` and `loop` events. I confirm I have signed the [Contributor License Agreement](https://docs.google.com/a/playcanvas.com/forms/d/1Ih69zQfJG-QDLIEpHr6CsaAs6fPORNOVnMv5nuo0cjk/viewform).